Links for 2011-02-10

  • Gerrit, Git and Jenkins : This is the future of code review. Commit directly from your git checkout to the Gerrit code-review system; change is immediately web-visible and enters the review workflow; at the same time, Jenkins checks out the proposed change and runs the test suite; once it’s approved, it automatically gets checked in. Brilliant!
    (tags: git coding code-review workflows jenkins gerrit c-i testing automation)

This entry was posted in Uncategorized. Bookmark the permalink. Both comments and trackbacks are currently closed.


  1. ben
    Posted February 10, 2011 at 21:51 | Permalink

    Uh, sure! Our test suite takes 75 minutes to run.

  2. Posted February 10, 2011 at 22:59 | Permalink

    ben: you need to break out the integration tests to start with. ;)

    But I’m not saying the checkin has to wait for the tests to complete anyway — test success is just another “vote” on the code review page, and the “approval” doesn’t necessarily require a test pass. It could be that sufficient approval for a checkin just requires a developer to approve the change, or indeed that at that stage of the branch lifecycle, it’s acceptable to check in immediately without any +1s (C-T-R in Apache terminology).